Building System: Only build one shared library for the user #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feng Yuan <[email protected]>
chunhuanMeng
changed the title
fengyuan14
reviewed
Jan 17, 2025
| list(APPEND TORCH_XPU_OPS_LIBRARIES torch_xpu_ops) | ||
| list(APPEND TORCH_XPU_OPS_LIBRARIES torch_xpu_ops_aten) | ||
| else() | ||
| add_library( |
There was a problem hiding this comment.
Please add comments why we need split objects into two separate archive libraries on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second phase of aligning binary distribution with CUDA. Currently, there is only libtorch_xpu.so on both windows and linux, but there are still some differences between win and lin, which we will fix after the sycl compiler is fixed.