Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizer] Ensure __USE_SPIR_BUILTIN__ has a value #16570

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jan 9, 2025

Ensure that __USE_SPIR_BUILTIN__ is defined to the value 0 when defined(__SPIR__) || defined(__SPIRV__) is false to fix build errors like this:

libdevice/include/sanitizer_defs.hpp:51:25: error: expected value in expression
   51 | #if __USE_SPIR_BUILTIN__
      |                         ^

Ensure that `__USE_SPIR_BUILTIN__` is defined to the the value `0` when
`defined(__SPIR__) || defined(__SPIRV__)` is false to fix build errors
like this:

    libdevice/include/sanitizer_defs.hpp:51:25: error: expected value in expression
       51 | #if __USE_SPIR_BUILTIN__
          |                         ^
@kbenzie kbenzie requested a review from a team as a code owner January 9, 2025 10:41
@kbenzie kbenzie changed the title Ensure __USE_SPIR_BUILTIN__ has a value [DeviceSanitizer] Ensure __USE_SPIR_BUILTIN__ has a value Jan 9, 2025
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@kbenzie
Copy link
Contributor Author

kbenzie commented Jan 9, 2025

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 531b76e into intel:sycl Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants