-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Matrix][E2E] Organize matrix tests #16563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @intel/sycl-matrix-reviewers agrees to this change, I think it would be better to break down this PR into two:
- NFC PR to relocate Matrix E2E tests into new folders (
Inputs
, andintel_matrix
) - Follow-up PR to remove
REQUIRES: aspect-ext_intel_matrix
from individual tests and add it to LIT config file.
That should make it easier to review the changes.
To be clear my motivation for this PR was to move the Let me know if these changes are agreeable, if so I'll go ahead and do what Udit suggested, and split this PR. Or also if there may be some other way to organize these tests that would be preferred. |
I don't see a value of moving out the Intel aspect. It may be desirable for users to see these aspects specified in each individual test. As for moving the .hpp files to a new folder seems to be fine. I don't have a strong opinion about it. |
In general, I think this is a positive change. I will not object to it. Some thoughts on top:
|
@dkhaldi @YuriPlyakhin I removed the reorganization of the
I tried this but it did not work for all tests, since some tests had to set variables between including llvm/sycl/test-e2e/Matrix/SG32/element_wise_all_ops_tf32.cpp Lines 14 to 19 in 38e6e1b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cherry pick this to xmain as there are other "inner" tests that need to follow these changes.
@intel/llvm-gatekeepers This should me ready to merge. The one failure is in an AddressSanitizer test which this pr doesnt touch. Possibly related to #16405, not entirely sure. |
Failures are different. From this PR:
From #16405:
Can you please submit a separate issue? |
Ok, opened up #16751 |
Move Matrix E2E test header files into the
Matrix/Inputs
folder. Also adds that folder to the included directories by adding to the%clangxx
expansion in theMatrix/lit.local.cfg
file to simplify the include statements.