[SYCL][COMPAT] Add helper function lop3() to perform bitwise logical operations on three input values based on the specified 8-bit truth table #16509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflinda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tomflinda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This is new functionality so this PR is missing a e2e test. |
JackAKirk
requested changes
Jan 3, 2025
| /// \returns The result | ||
| inline uint32_t lop3(uint32_t a, uint32_t b, uint32_t c, uint8_t lut) { | ||
| uint32_t result = 0; | ||
|
|
There was a problem hiding this comment.
It is better to use the optimized instructions for backends when available, so that translation does not reduce performance wrt cuda.
Suggested change
| #if defined(__SYCL_DEVICE_ONLY__) && defined(__NVPTX__) | |
| asm volatile("lop3.b32 %0, %1, %2, %3, %4;" | |
| : "=r"(result) | |
| : "r"(a), "r"(b), "r"(c), "r"(lut)); | |
| #else |
See later corresponding #endif suggestion
| // Set the output bit in the result | ||
| result |= (output_bit << i); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| #endif // defined(__SYCL_DEVICE_ONLY__) && defined(__NVPTX__) |
…operations on three input values based on the specified 8-bit truth table Signed-off-by: chenwei.sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenwei.sun [email protected]