[UR] Enable hwloc in UMF linux build

[PatKamin]

Update UR to statically link UMF with hwloc on Linux.
This will enable hwloc support in UMF on Linux.

Also, always use the v2.9.3 hwloc version for hwloc builds.

[PatKamin]

Drafted until the UMF fix is pulled down to llvm via UMF update in UR.

[PatKamin]

Drafted until the UMF fix is pulled down to llvm via UMF update in UR.

Fix is now pulled down, ready for review.

[igchor]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

[PatKamin]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

Right, now it will automatically be downloaded - deleted user requirement.

[bader]

Update UR to statically link hwloc v2.9.3 both on linux and Windows.

If I get the change right, the dependency on hwloc still exists. The change removed the runtime dependency, but not the compile time dependency. Am I right?

This document describes the environment for DPC++ compiler developers, not DPC++ compiler users.

Your change seems to raise the version requirement. Please, update the hwloc version to 2.9.3.

[PatKamin]

The hwloc library will always be fetched from sources. Regardless of hwloc-dev packages user has installed, the fetched version will be linked with the UMF library. That's why I remove hwloc from this dependencies list, as the user-installed hwloc-dev package will not be used by UMF.

[bader]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

Right, now it will automatically be downloaded - deleted user requirement.

If hwloc dependencies will be automatically resolved by CMake, please, remove installation of these dependencies from CI scripts. Specifically, from

llvm/devops/scripts/install_build_tools.sh

Line 26 in 7cc9e80

libhwloc-dev \

and

llvm/.github/workflows/sycl-docs.yml

Line 36 in 7cc9e80

sudo apt-get install -y graphviz ssh ninja-build libhwloc-dev

.

[PatKamin]

@bader, I've added an automake dependency for building hwloc.

[bader]

Also, always use the v2.9.3 hwloc version for hwloc builds.

I've added an automake dependency for building hwloc.

If we always use fixed version of the library, I prefer CMake to use the pre-built binaries. Building it from sources is unnecessary overhead.

WRT adding dependency on automake for building hwloc, I'd like @AlexeySachkov to approve this.

[PatKamin]

If we always use fixed version of the library, I prefer CMake to use the pre-built binaries. Building it from sources is unnecessary overhead.

I can make it a fallback: first search for hwloc binaries installed in the system, if not found - fetch hwloc from sources. I would also remove specifying the exact hwloc version in llvm leaving it to UMF to decide on version. @bader, what do you think?

[bader]

If we always use fixed version of the library, I prefer CMake to use the pre-built binaries. Building it from sources is unnecessary overhead.

I can make it a fallback: first search for hwloc binaries installed in the system, if not found - fetch hwloc from sources. I would also remove specifying the exact hwloc version in llvm leaving it to UMF to decide on version. @bader, what do you think?

I suggest we fetch binaries instead of sources.
https://www.open-mpi.org/software/hwloc/v2.9/ has links to the binaries for different platforms.

hwloc handling must be done in UMF CMake files.

[PatKamin]

WRT adding dependency on automake for building hwloc, I'd like @AlexeySachkov to approve this.

@AlexeySachkov, is it ok to add automake dependency?