Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Refactor/fix bfloat16 test #14062

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

aelovikov-intel
Copy link
Contributor

Fixes ansi-alias violation and reads from uninitialized buffers. Fixes #13790.

@aelovikov-intel aelovikov-intel requested review from a team as code owners June 5, 2024 21:56
@aelovikov-intel
Copy link
Contributor Author

Substitutes #14059.

Fixes ansi-alias violation and reads from uninitialized buffers.
Fixes intel#13790.
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes looks good to me. I'm wondering if we should also extend this test to also test for BF16 builtins on the host?

@aelovikov-intel
Copy link
Contributor Author

I'm wondering if we should also extend this test to also test for BF16 builtins on the host?

That would be an unrelated change.

@uditagarwal97
Copy link
Contributor

I'm wondering if we should also extend this test to also test for BF16 builtins on the host?

That would be an unrelated change.

That can be done in a separate PR, not necessarily now.

@aelovikov-intel
Copy link
Contributor Author

That can be done in a separate PR, not necessarily now.

Just to be clear, I'm not planning on working on that.

@uditagarwal97
Copy link
Contributor

That can be done in a separate PR, not necessarily now.

Just to be clear, I'm not planning on working on that.

That's fine - I can create an internal tracker for this.

@aelovikov-intel
Copy link
Contributor Author

Failures are unrelated. Since this is a one test change to fix flaky issue merging without green CI.

@aelovikov-intel aelovikov-intel merged commit 463f00c into intel:sycl Jun 6, 2024
11 of 14 checks passed
@aelovikov-intel aelovikov-intel deleted the fix-bfloat16-test branch June 6, 2024 16:29
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
Fixes ansi-alias violation and reads from uninitialized buffers. Fixes
intel#13790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] BFloat16/bfloat16_builtins.cpp failed in SYCL Nightly on OCL AMD and 12 Gen Intel i9 CPU
3 participants