Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce the steady stream of dependabot PRs #138

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Feb 6, 2024

PR #107 introduced dependabot to the repository to update GitHub Actions. This results in a weekly stream of PRs to incorporate every tiny patch update for every GitHub Action we use here. This results in a lot of churn and I do not have any sense that it improves the code quality in any way. Instead, it may in fact be the cause of the breakage in the release workflow, since that relies on upload-artifact which dependabot bumped from v3.1.3 to v4.0.0 (see #126).

What this change does is follow GitHub's guidance to only receive security updates. Since "dependabot security updates" are enabled, we don't need to follow each action update; setting
open-pull-requests-limit to 0 mutes the dependabot PRs but we should still see any security alerts in the security tab.

PR intel#107 introduced dependabot to the repository to update GitHub
Actions. This results in a weekly stream of PRs to incorporate every
tiny patch update for every GitHub Action we use here. This results in a
lot of churn and I do not have any sense that it improves the code
quality in any way. Instead, it may in fact be the cause of the breakage
in the release workflow, since that relies on `upload-artifact` which
dependabot bumped from v3.1.3 to v4.0.0.

What this change does is follow GitHub's [guidance] to only receive
security updates. Since "dependabot security updates" are enabled, we
don't need to follow each action update; setting
`open-pull-requests-limit` to 0 mutes the dependabot PRs but we should
still see any security alerts in the security tab.

[guidance]: https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file
@abrown
Copy link
Contributor Author

abrown commented Feb 6, 2024

Other options:

  • downgrade the schedule to monthly
  • ignore update types like patch, etc.

cc: @rahulchaphalkar

@rahulchaphalkar
Copy link
Contributor

Thanks for bringing this up, the weekly updates on GitHub actions are definitely not needed. I know we discussed changing the frequency to monthly and/or ignoring certain types of updates, but even just changing the PRs to 0 as you have done should be enough.
LGTM (y)

@abrown abrown merged commit 9fdc830 into intel:master Feb 10, 2024
12 checks passed
@abrown abrown deleted the mute-dependabot branch February 10, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants