🐛 Fix ambiguity with ct
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `ct` must use a function template to obtain overloads for both type template parameters and NTTPs. However when using `ct` with an NTTP placeholder type there is an ambiguity if the NTTP is not deduced: e.g. if a non-deduced `ct_string` is passed, both the `auto` overload and the `ct_string` overloads match. Solution: - Introduce another NTTP placeholder type, `ct_helper` that can be partially specialized (without definition) to disable the primary template specialization.
elbeno
force-pushed
the
fix-ct-ambiguity
branch
from
ada25d3 to
f41324b
Compare
mjcaisse-intel
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
ctmust use a function template to obtain overloads for both type template parameters and NTTPs. However when usingctwith an NTTP placeholder type there is an ambiguity if the NTTP is not deduced: both theautooverload and thect_stringoverloads match.Solution:
ct_helperthat can be partially specialized without definition to disable the primary template specialization.