Skip to content

Commit

Permalink
package: fix package version deduction
Browse files Browse the repository at this point in the history
We should check if variables NEO_VERSION_MAJOR, NEO_VERSION_MINOR and
NEO_VERSION_BUILD are defined instead of checking for values. this
allows to set values like '0' which was expanded to false.

Change-Id: I0ceaf0e19053cae29bee78e77f574b92771e2d3f
Signed-off-by: Artur Harasimiuk <[email protected]>
  • Loading branch information
ArturHarasimiuk authored and Compute-Runtime-Automation committed Apr 27, 2018
1 parent aee6d10 commit 21f2350
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions package.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ if(UNIX)
set(package_input_dir ${IGDRCL_BINARY_DIR}/packageinput)
set(package_output_dir ${IGDRCL_BINARY_DIR}/packages)

if(NOT NEO_VERSION_MAJOR)
if(NOT DEFINED NEO_VERSION_MAJOR)
set(NEO_VERSION_MAJOR 1)
endif()
if(NOT NEO_VERSION_MINOR)
if(NOT DEFINED NEO_VERSION_MINOR)
set(NEO_VERSION_MINOR 0)
endif()
if(NOT NEO_VERSION_BUILD)
if(NOT DEFINED NEO_VERSION_BUILD)
set(NEO_VERSION_BUILD 0)
endif()

Expand Down

0 comments on commit 21f2350

Please sign in to comment.