Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: download latest spike sorting BWM #167

Merged
merged 3 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog
## [Latest](https://github.com/int-brain-lab/ONE/commits/main) [2.11.1]
## [Latest](https://github.com/int-brain-lab/ONE/commits/main) [2.11.2]

### Modified

- HOTFIX: non-default specified revisions are not ignored anymore (passed down revision argument)
- Registration tests against Alyx > 3.2 expect empty strings as Null collections

## [2.11.1]

### Modified

Expand Down
2 changes: 1 addition & 1 deletion one/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
"""The Open Neurophysiology Environment (ONE) API."""
__version__ = '2.11.1'
__version__ = '2.11.2'
2 changes: 1 addition & 1 deletion one/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ def load_object(self,
"""
query_type = query_type or self.mode
datasets = self.list_datasets(
eid, details=True, query_type=query_type, keep_eid_index=True)
eid, details=True, query_type=query_type, keep_eid_index=True, revision=revision)

if len(datasets) == 0:
raise alferr.ALFObjectNotFound(obj)
Expand Down
4 changes: 2 additions & 2 deletions one/tests/test_registration.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def test_register_files(self):
r, = self.client.register_files(file_list=[file])
self.assertEqual(r['revision'], rev['name'])
self.assertTrue(r['default'])
self.assertIsNone(r['collection'])
self.assertEqual('', r['collection'])

# Register exact dataset revision again - it should append an 'a'
# When we re-register the original it should move them into revision with today's date
Expand All @@ -337,7 +337,7 @@ def test_register_files(self):
file = files[1].parent.joinpath(f'#{r2["revision"]}#', file.name)
self.assertTrue(file.exists())

self.assertIsNone(r3['revision'])
self.assertEqual('', r3['revision'])
self.assertTrue(files[2].exists())

# Protect the latest datasets
Expand Down
Loading