-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag guard #1625
Conversation
…ixed Bugs, improved UI for HeathState, Added Documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
============================================
+ Coverage 78.38% 78.54% +0.16%
- Complexity 2520 2570 +50
============================================
Files 257 266 +9
Lines 8257 8435 +178
Branches 984 995 +11
============================================
+ Hits 6472 6625 +153
- Misses 1358 1376 +18
- Partials 427 434 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 9 files at r1, 8 of 23 files at r2, 7 of 255 files at r3, 223 of 240 files at r4, 1 of 2 files at r6, 33 of 35 files at r7, 5 of 5 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Dimi-Ma)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 9 files at r1, 8 of 23 files at r2, 7 of 255 files at r3, 229 of 240 files at r4, 1 of 2 files at r6, 33 of 35 files at r7, 5 of 5 files at r8, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @EddeCCC)
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java
line 330 at r7 (raw file):
} public List<ExportMetricsServiceRequest> getMetricRequests() {
This function seems to not be used and could be removed
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java
line 373 at r7 (raw file):
} public OtlpGrpcServer getGrpcServer() {
same as above
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/selfmonitoring/AgentHealthIncidentBufferTest.java
line 39 at r8 (raw file):
} @Test void verifyBufferSize() {
this test is redundant.
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/selfmonitoring/AgentHealthManagerDeadlockGh1597IntTest.java
line 52 at r7 (raw file):
long start = System.currentTimeMillis(); while (System.currentTimeMillis() - start < millisToRun) { cut.invalidateIncident(cut.getClass(), "Invalidation due to invalidator event");
Maybe it would be better to use a more descriptive message here.
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/selfmonitoring/AgentHealthManagerTest.java
line 41 at r7 (raw file):
@Test void verifyAgentHealthChangedEvent() {
This Test exists 2 times with the same name, one with invalidator as null and one where its set. Do these tests show the same result? The other test is under the nested class TimeoutHealth
if its supposed to show something different it is not apparent from how the test is written. (goes for the other tests too since there are some duplicates with only the `ìnvalidator`` being a different value but having the same test name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 65 of 65 files at r9, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EddeCCC)
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/selfmonitoring/AgentHealthIncidentBufferTest.java
line 39 at r8 (raw file):
Previously, Dimi-Ma (Dimitiros Mantas) wrote…
this test is redundant.
Expected value is mocked so the test case is not valid and can be removed.
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/selfmonitoring/AgentHealthManagerTest.java
line 41 at r7 (raw file):
Previously, Dimi-Ma (Dimitiros Mantas) wrote…
This Test exists 2 times with the same name, one with invalidator as null and one where its set. Do these tests show the same result? The other test is under the nested class
TimeoutHealth
if its supposed to show something different it is not apparent from how the test is written. (goes for the other tests too since there are some duplicates with only the `ìnvalidator`` being a different value but having the same test name.
The changes are fine but the naming can still be improved. It would be better to have a distinct name for each test to represent what is being tested in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r10, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EddeCCC)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/hook/actions/span/WriteSpanAttributesAction.java
line 4 at r10 (raw file):
import io.opentelemetry.api.trace.Span; import lombok.*;
Do we want to group together imports of the same library if so when should be the the trigger set?
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/instrumentation/hook/MethodHookGeneratorTest.java
line 30 at r10 (raw file):
import rocks.inspectit.ocelot.core.testutils.Dummy; import java.util.*;
Same here, is this grouping really needed?
Pull-Requested was approved. By-Passing to avoid unnecessary delay. |
Add TagGuard, which enables to limit all or specific tags in measurements
This change is