Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dependency checks #1623

Merged
merged 15 commits into from
Nov 9, 2023
Merged

Feature dependency checks #1623

merged 15 commits into from
Nov 9, 2023

Conversation

TitusLabs
Copy link
Contributor

@TitusLabs TitusLabs commented Nov 3, 2023

change to version catalog and integrate dependency plugins
plus gradle and some dependency updates
add dependencyCheckAnalyze step (at the moment without failBuildOnCVSS)


This change is Reviewable

@TitusLabs TitusLabs requested a review from EddeCCC November 3, 2023 14:54
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1623 (dbb7f41) into master (61429e4) will decrease coverage by 0.03%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head dbb7f41 differs from pull request most recent head e164cac. Consider uploading reports for the commit e164cac to get more accurate results

@@             Coverage Diff              @@
##             master    #1623      +/-   ##
============================================
- Coverage     78.39%   78.36%   -0.03%     
  Complexity     2518     2518              
============================================
  Files           257      257              
  Lines          8247     8257      +10     
  Branches        983      984       +1     
============================================
+ Hits           6465     6470       +5     
- Misses         1355     1359       +4     
- Partials        427      428       +1     

see 5 files with indirect coverage changes

Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 18 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TitusLabs)

@TitusLabs TitusLabs merged commit caddf26 into master Nov 9, 2023
@TitusLabs TitusLabs deleted the feature-dependency-checks branch November 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants