Fix bugs and improve tracing #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to know what the bugs were. Also needs to be updated to current |
colll78
commented
Dec 28, 2024
| @@ -88,7 +90,7 @@ mkProgrammableLogicMinting :: ClosedTerm (PAsData PCredential :--> PAsData PCurr | |||
| mkProgrammableLogicMinting = plam $ \programmableLogicBase nodeCS mintingLogicCred ctx -> P.do | |||
| ctxF <- pletFields @'["txInfo", "redeemer", "scriptInfo"] ctx | |||
| infoF <- pletFields @'["referenceInputs", "outputs", "mint", "wdrl"] ctxF.txInfo | |||
| let red = punsafeCoerce @_ @_ @PSmartTokenMintingAction (pto ctxF.redeemer) | |||
| let red = punsafeCoerce @_ @_ @(PAsData PSmartTokenMintingAction) (pto ctxF.redeemer) | |||
There was a problem hiding this comment.
Bug 1. This type is actually data encoded but it was unsafeCoerced into non-data encoding.
| @@ -109,12 +111,12 @@ mkProgrammableLogicMinting = plam $ \programmableLogicBase nodeCS mintingLogicCr | |||
| # plam (pfstBuiltin #) | |||
| # pto (pfromData infoF.wdrl) | |||
|
|
|||
| pmatch red $ \case | |||
| pmatch (pfromData red) $ \case | |||
There was a problem hiding this comment.
Because it is data encoded we need to use fromData to apply pasInt to get the underlying integer to branch on.
| , phasUTxO # oref # infoF.inputs | ||
| [ ptraceInfoIfFalse "token name mismatch" $ ownTokenName #== pprotocolParamsTokenData | ||
| , ptraceInfoIfFalse "incorrect minted amount" $ ownNumMinted #== pconstantData 1 | ||
| , ptraceInfoIfFalse "init UTxO not present" $ phasUTxO # oref # pfromData infoF.inputs |
There was a problem hiding this comment.
Bug 2. This list was data encoded so we should have applied fromData to pasList to convert from BuiltinData to BuiltinList
| ) | ||
| # infoF.referenceInputs | ||
| # pfromData infoF.referenceInputs |
| @@ -188,8 +154,12 @@ isHeadNode = plam $ \node -> | |||
|
|
|||
| isTailNode :: ClosedTerm (PAsData PDirectorySetNode :--> PBool) | |||
| isTailNode = plam $ \node -> | |||
| pfield @"next" # node #== pemptyCSData | |||
| pfield @"next" # node #== ptailNextData | |||
There was a problem hiding this comment.
Bug 3. isTail should check that next is the tail currency symbol (highest possible lexographic CS).
|
Ok thanks! |
|
closed in-favor of #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed a few bugs in the onchain code and improved tracing.