Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Offchain code cleanup #415

Merged
merged 3 commits into from
Jan 22, 2025
Merged

change: Offchain code cleanup #415

merged 3 commits into from
Jan 22, 2025

Conversation

AmbientTea
Copy link
Contributor

Description

  • uses existing helpers where they weren't before
  • adds some more helpers to make transaction logic cleaner

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea requested review from kpinter-iohk, gilligan, LGLO and jankun4 and removed request for kpinter-iohk, gilligan and LGLO January 22, 2025 15:27
@AmbientTea AmbientTea marked this pull request as ready for review January 22, 2025 15:28
@AmbientTea AmbientTea merged commit 53e588c into master Jan 22, 2025
11 checks passed
@AmbientTea AmbientTea deleted the offchain-cleanup branch January 22, 2025 16:19
skylar-simoncelli pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants