Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use partner-chains-node to initialize partner chain in local-environment #402

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Jan 20, 2025

Description

local-environment will use container based on PARTNER_CHAINS_NODE_IMAGE to setup candidates and d-param.

pc-contracts-cli image stays until E2E-tests are updated and wizards are moved into into the node binary.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@LGLO LGLO force-pushed the ETCM-9051-use-partner-chains-node-in-local-env-setup branch 11 times, most recently from e768497 to 41cc8ad Compare January 22, 2025 16:44
@LGLO LGLO marked this pull request as ready for review January 22, 2025 19:03
Earthfile Show resolved Hide resolved
Copy link
Contributor

@AmbientTea AmbientTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@LGLO LGLO force-pushed the ETCM-9051-use-partner-chains-node-in-local-env-setup branch from a2c71fb to 3f25ced Compare January 23, 2025 20:31
@LGLO LGLO enabled auto-merge (squash) January 23, 2025 20:31
@LGLO LGLO merged commit 68874f9 into master Jan 24, 2025
12 checks passed
@LGLO LGLO deleted the ETCM-9051-use-partner-chains-node-in-local-env-setup branch January 24, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants