-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add upsert-permissioned-candidates smart-contracts node command #382
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,52 @@ | ||||||
use crate::parse_partnerchain_public_keys; | ||||||
use crate::PaymentFilePath; | ||||||
use ogmios_client::jsonrpsee::client_for_url; | ||||||
use partner_chains_cardano_offchain::await_tx::FixedDelayRetries; | ||||||
use partner_chains_cardano_offchain::permissioned_candidates::upsert_permissioned_candidates; | ||||||
use sidechain_domain::AuraPublicKey; | ||||||
use sidechain_domain::GrandpaPublicKey; | ||||||
use sidechain_domain::PermissionedCandidateData; | ||||||
use sidechain_domain::SidechainPublicKey; | ||||||
use sidechain_domain::UtxoId; | ||||||
use std::fs::read_to_string; | ||||||
|
||||||
#[derive(Clone, Debug, clap::Parser)] | ||||||
pub struct UpsertPermissionedCandidatesCmd { | ||||||
#[clap(flatten)] | ||||||
common_arguments: crate::CommonArguments, | ||||||
/// Path to the file containing the permissioned candidates data. | ||||||
/// Each line represents one permissioned candidate in format SIDECHAIN_KEY:AURA_KEY:GRANDPA_KEY | ||||||
#[arg(long)] | ||||||
permissioned_candidates_file: String, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Help is missing here. How is user supposed to know it should be colon separated CSV? |
||||||
#[clap(flatten)] | ||||||
payment_key_file: PaymentFilePath, | ||||||
#[arg(long, short('c'))] | ||||||
genesis_utxo: UtxoId, | ||||||
} | ||||||
|
||||||
impl UpsertPermissionedCandidatesCmd { | ||||||
pub async fn execute(self) -> crate::CmdResult<()> { | ||||||
let payment_key = self.payment_key_file.read_key()?; | ||||||
|
||||||
let mut permissioned_candidates = Vec::new(); | ||||||
|
||||||
for line in read_to_string(&self.permissioned_candidates_file).unwrap().lines() { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of unwrap, please map it to a message that points user what file is missing. |
||||||
let permissioned_candidate = parse_partnerchain_public_keys(line) | ||||||
.map_err(|e| format!("Failed to parse permissioned candidate: {}", e))?; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
permissioned_candidates.push(permissioned_candidate); | ||||||
} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Just because I have |
||||||
|
||||||
let client = client_for_url(&self.common_arguments.ogmios_url).await?; | ||||||
|
||||||
upsert_permissioned_candidates( | ||||||
self.genesis_utxo, | ||||||
&permissioned_candidates, | ||||||
payment_key.0, | ||||||
&client, | ||||||
&FixedDelayRetries::two_minutes(), | ||||||
) | ||||||
.await?; | ||||||
|
||||||
Ok(()) | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up, 36% of these imports are unused