aggregator: fix flakiness of tests that uses the snapshotter and simplify http server tests #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters Before the module and name params had to be of the same type (str if str, string if string, ...) now we can mixed them (ie str for module and string for name). Co-authored-by: Damien Lachaume <[email protected]>
Calling `set_sub_temp_dir` would always remove the parent directory of the subdirectory that the caller asked to create, leading to flakiness as if two tests called it they could remove data from each others.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Test Results 4 files ±0 52 suites ±0 10m 18s ⏱️ -1s Results for commit a456b7f. ± Comparison against base commit c54bf77. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…ver base path Co-authored-by: Damien Lachaume <[email protected]>
Alenar
force-pushed
the
ensemble/aggregator/fix-flakiness+simplify-http-server-tests
branch
from
5022f7c to
2387c7f
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
* mithril-aggregator from `0.6.17` to `0.6.18` * mithril-common from `0.4.106` to `0.4.107`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
deleted the
ensemble/aggregator/fix-flakiness+simplify-http-server-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes:
snapshotterarchive verification introduced in ca3f524.SERVER_BASE_PATHas the tests don't need it.Pre-submit checklist