refactor(aggregator): better url sanitization process by using a value object #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Jan 22, 2025
| internal_url: Url, | ||
| } | ||
|
|
||
| impl SanitizedUrl { |
There was a problem hiding this comment.
This structure represent a Uri that is not a resource.
We may named it to reflect that.
SanitizedUrl doesn't mean much. This gives the impression of having a valid Url
There was a problem hiding this comment.
We share this concern but could not find a name that would fit that description.
Since we could not find anything better we renamed it to SanitizedUrlWithTrailingSlash with hope we found a better name in the future.
Alenar
force-pushed
the
ensemble/2234/incremental-db-artifact-production-optimizations
branch
from
b630878 to
0db35ae
Compare
Base automatically changed from
ensemble/2234/incremental-db-artifact-production-optimizations
to
main
January 22, 2025 16:59
Alenar
force-pushed
the
ensemble/aggregator/refactor_url_sanitizer
branch
from
33f7afc to
9db66d8
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
force-pushed
the
ensemble/aggregator/refactor_url_sanitizer
branch
from
9db66d8 to
18e7535
Compare
…e object This `SanitizedUrlWithTrailingSlash` struct allow to avoid redundant call to the url sanitizer as it guarantee that the url that it hold is already sanitized. Co-authored-by: Damien Lachaume <[email protected]>
* mithril-aggregator from `0.6.18` to `0.6.19`
Alenar
force-pushed
the
ensemble/aggregator/refactor_url_sanitizer
branch
from
18e7535 to
d65c60a
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR introduce a
SanitizedUrlWithTrailingSlashstruct to avoid redundant call to the url sanitizer as it guarantee that the url that it hold is already sanitized.Pre-submit checklist