Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add workflows to Nightly Dispatcher #2188

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 19, 2024

Content

This PR includes the trigger of new workflows with the Nightly Dispatcher:

  • Aggregator Stress Test workflow
  • Client Multi Platform workflow

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2177

@jpraynaud jpraynaud self-assigned this Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Test Results

    4 files  ±0     52 suites  ±0   10m 31s ⏱️ +7s
1 465 tests ±0  1 465 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 721 runs  ±0  1 721 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ace5ab2. ± Comparison against base commit cda6530.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2177-extend-nightly-dispatcher branch from 1443650 to ec9f5ae Compare January 2, 2025 11:30
@jpraynaud jpraynaud marked this pull request as ready for review January 2, 2025 12:18
@jpraynaud jpraynaud requested review from sfauvel and dlachaume January 2, 2025 12:19
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to set the environment variables with schedule events for the test-docker job.

.github/workflows/nightly-dispatcher.yml Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/2177-extend-nightly-dispatcher branch 4 times, most recently from 97a8401 to 8e0e30d Compare January 2, 2025 14:32
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/2177-extend-nightly-dispatcher branch from 8e0e30d to ace5ab2 Compare January 2, 2025 14:34
@jpraynaud
Copy link
Member Author

I think we also need to set the environment variables with schedule events for the test-docker job.

Yes, I have refactored the code to do the computation in a prepare job and use its outputs in other jobs 👍

@jpraynaud jpraynaud requested a review from dlachaume January 2, 2025 14:51
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 2, 2025 14:51 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 7a3ebd3 into main Jan 2, 2025
61 of 64 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2177-extend-nightly-dispatcher branch January 2, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run nightly Aggregator Stress Test and Client Multi Platform workflows
3 participants