Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: seamless unstable to stable transition in WASM client #1914

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Refactor: seamless unstable to stable transition in WASM client #1914

merged 9 commits into from
Sep 4, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 3, 2024 •
edited
Loading

Content

This PR includes an update of the support of unstable features in the WASM client:

  • the unstable client has been removed
  • the client options have a new unstable flag (activated for WASM only)
  • the WASM client enforces the usage of the unstable flag for unstable features
  • when transitioning from unstable to stable there is no more breaking change for the users

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1911

@jpraynaud jpraynaud self-assigned this Sep 3, 2024
@jpraynaud jpraynaud force-pushed the jpraynaud/1911-seamless-stable-unstable-features-client-wasm branch from da0c03e to 58ca039 Compare September 3, 2024 16:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Test Results

    4 files  ±0     53 suites  ±0   9m 34s ⏱️ -4s
1 247 tests ±0  1 247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 458 runs  ±0  1 458 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b0eaa98. ± Comparison against base commit 1beeae8.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet September 3, 2024 16:30 — with GitHub Actions Inactive
@jpraynaud
feat: add 'unstable' option for WASM client in 'ClientOptions'
0d417f3 
This new feature will allow the usage of 'unstable' features by the WASM
client.
@jpraynaud
refactor: refactor unstable feature implementation in WASM client
d8615b3 
The 'MithrilUnstableClient' has been removed and replaced by the usage
of an 'unstable' field in the client options.
@jpraynaud
refactor: adapt the WASM client example to work with new unstable imp…
ccb0b10 
…lementation
@jpraynaud
docs: update 'Mithril client library WASM' developer doc
30e9057 
With new unstable features implementation.
@jpraynaud
chore: avoid watching 'node_modules' files in client WASM test servers
b779826
@jpraynaud
refactor: adapt the WASM client www tests with new unstable implement…
76e14c7 
…ation
@jpraynaud
refactor: adapt explorer to new unstable implementation in WASM client
2701667
@jpraynaud jpraynaud force-pushed the jpraynaud/1911-seamless-stable-unstable-features-client-wasm branch from 58ca039 to 72ac81e Compare September 4, 2024 09:42
@jpraynaud jpraynaud force-pushed the jpraynaud/1911-seamless-stable-unstable-features-client-wasm branch from 72ac81e to a3362fd Compare September 4, 2024 09:49
@jpraynaud
chore: bump crates versions
b0eaa98 
- 'mithril-client-wasm' from '0.3.10' to '0.4.0'
- 'mithril-client' from '0.8.16' to '0.8.17'
- 'mithril-explorer' from '0.7.5' to '0.7.6'.
@jpraynaud jpraynaud force-pushed the jpraynaud/1911-seamless-stable-unstable-features-client-wasm branch from a3362fd to b0eaa98 Compare September 4, 2024 10:00
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet September 4, 2024 10:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from Alenar and sfauvel September 4, 2024 10:54
@jpraynaud jpraynaud marked this pull request as ready for review September 4, 2024 10:54
sfauvel
sfauvel approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit 899f86c into main Sep 4, 2024
45 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1911-seamless-stable-unstable-features-client-wasm branch September 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seamless transition of features from unstable to stable in client WASM
3 participants
@jpraynaud @Alenar @sfauvel