Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt multi platform test for Cardano transactions #1518

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Adapt multi platform test for Cardano transactions #1518

merged 3 commits into from
Feb 23, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 21, 2024 •
edited
Loading

Content

This PR includes update to the GitHub Actions workflow Mithril Client multi-platform test to support testing for Cardano transactions.

  • Implementation of a conditional step to certify Cardano transactions if the aggregator capability is enabled.
  • Fix function names in mithril-client-wasm/www-test/index.js to ensure consistency in test naming.

Run on testing-sanchonet with Cardano transaction signing capability:
https://github.com/input-output-hk/mithril/actions/runs/8020577209

Run on testing-preview without Cardano transaction signing capability:
https://github.com/input-output-hk/mithril/actions/runs/8020604356

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1510

@dlachaume dlachaume self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results

  3 files  ±0   42 suites  ±0   8m 25s ⏱️ -27s
865 tests ±0  865 ✅ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4b32967. ± Comparison against base commit 5afc6fc.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 21, 2024 18:33 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch 11 times, most recently from 1bc15c4 to b2167cd Compare February 22, 2024 13:11
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 22, 2024 13:27 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch from b2167cd to 1620c99 Compare February 22, 2024 13:28
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 22, 2024 13:40 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch 5 times, most recently from fcb727a to 4430801 Compare February 22, 2024 15:22
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 22, 2024 15:42 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review February 22, 2024 16:24
@dlachaume dlachaume requested a review from sfauvel February 22, 2024 16:45
Alenar
Alenar reviewed Feb 22, 2024
View reviewed changes
.github/workflows/test-client.yml Outdated Show resolved Hide resolved
.github/workflows/test-client.yml Outdated Show resolved Hide resolved
.github/workflows/test-client.yml Outdated Show resolved Hide resolved
.github/workflows/test-client.yml Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch from 4c1d9cd to 74f4464 Compare February 23, 2024 08:52
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch 3 times, most recently from 151a364 to 6156556 Compare February 23, 2024 11:04
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch from 6156556 to 266db9a Compare February 23, 2024 11:08
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 23, 2024 11:16 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments to fix prior to merging.

.github/workflows/test-client.yml Show resolved Hide resolved
.github/workflows/test-client.yml Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch 2 times, most recently from c0ffdf7 to f4c81dc Compare February 23, 2024 14:12
@dlachaume dlachaume force-pushed the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch from f4c81dc to 4b32967 Compare February 23, 2024 14:20
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 23, 2024 14:28 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 52fa7d3 into main Feb 23, 2024
50 of 58 checks passed
@dlachaume dlachaume deleted the damien/1510/adapt-multi-platform-test-for-cardano-transactions branch February 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt Mithril Client multi-platform test for Cardano Transactions
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud