Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change introduced with mithril-client-cli using mithril-client library #1398

Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Dec 14, 2023

Content

This PR includes a fix on a breaking change introduced by the PR #1395.

Some commands of mithril-client-cli (snapshot show, snapshot list and msd list) don't need to a genesis_verification_key configured to be runned.

Now that mithril-client-cli uses the mithril-client-cli that needs a genesis_verification_key to build a Client, we have to provide a value, even for commands that don't need it.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume self-assigned this Dec 14, 2023
Copy link

github-actions bot commented Dec 14, 2023

Test Results

    3 files  ±0    30 suites  ±0   7m 38s ⏱️ +7s
726 tests ±0  726 ✔️ ±0  0 💤 ±0  0 ±0 
795 runs  ±0  795 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9acc854. ± Comparison against base commit 2670a43.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the damien/fix-mithril-client-cli-genesis-verification-key-missing branch from bdd6d52 to 9acc854 Compare December 14, 2023 15:41
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume merged commit 84308dd into main Dec 14, 2023
38 of 39 checks passed
@dlachaume dlachaume deleted the damien/fix-mithril-client-cli-genesis-verification-key-missing branch December 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants