Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extracting transaction witness #327

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Aug 7, 2024

Description

Extracting transaction witness

Related Issue(s)

List the issue numbers related to this pull request.

Closes #326

Description of Changes

  • Create a new dash map where key is the witness publickey hash using blake2b with size 24 and the value is the actual public key and the transaction number that this witness exist.
  • A function to check whether the hash is in the provided tx number.
  • A function to get the actual public key from the hash.
  • Test case for Alonzo block is provided.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Aug 7, 2024
@bkioshn bkioshn added the enhancement New feature or request label Aug 7, 2024
@bkioshn bkioshn added this to the M3: Hermes Essential Modules milestone Aug 7, 2024
@bkioshn bkioshn added the review me PR is ready for review label Aug 7, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small changes requested

hermes/crates/cardano-chain-follower/src/witness.rs Outdated Show resolved Hide resolved
@bkioshn bkioshn requested a review from stevenj August 8, 2024 03:54
@stevenj stevenj removed this from the M3: Hermes Essential Modules milestone Aug 9, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 6d8d714 into feat/auto-sync-mithril Aug 13, 2024
9 of 13 checks passed
@stevenj stevenj deleted the feat/tx-witness branch August 13, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants