Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow except tests #179

Closed
wants to merge 3 commits into from
Closed

feat: allow except tests #179

wants to merge 3 commits into from

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Dec 7, 2023

Description

This PR changes the clippy lint from allow-unwrap-in-tests to allow-except-in-tests, to make sure the tests are better commented

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 self-assigned this Dec 7, 2023
@kukkok3
Copy link
Contributor Author

kukkok3 commented Dec 7, 2023

@jmgilman any idea why this is failing? I did modify clippy.toml in catalyst-ci first

@Mr-Leshiy
Copy link
Contributor

@kukkok3 If want to update some stuff related to the Earthly build, you also need to bump catalyst-ci version in Earthfiles.
As for example here

FROM github.com/input-output-hk/catalyst-ci/earthly/rust:v2.0.11+rust-base
.

But don't worry, I will apply this update in this PR #173. So I think we can close this PR

@Mr-Leshiy Mr-Leshiy closed this Dec 11, 2023
@github-actions github-actions bot deleted the feat-allow-except-tests branch January 26, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants