Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Project duration months picker #1718

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

LynxLynxx
Copy link
Contributor

Description

User can select value from dropdown menu. Values inside of the dropdown are calculated from values between min and max from json schema.

Related Issue(s)

Closes #1564

Description of Changes

  • creating new duration widget
  • fixing menu width in dropdown selection
  • adding validation to dropdown selection widget

Screenshots

Nagranie.z.ekranu.2025-01-28.o.23.28.31.mov

Uploading Nagranie z ekranu 2025-01-28 o 23.25.48.mov…

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues F14 labels Jan 28, 2025
@LynxLynxx LynxLynxx added this to the Fund14 Technical Readiness milestone Jan 28, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 28, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@LynxLynxx LynxLynxx marked this pull request as ready for review January 29, 2025 07:40
dtscalac
dtscalac previously approved these changes Jan 29, 2025
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (make sure to resolve conflicts)

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 430/434}$ | ${\color{red}Fail: 4/434}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 448/448}$ | ${\color{red}Fail: 0/448}$ |

@LynxLynxx LynxLynxx enabled auto-merge (squash) January 29, 2025 14:09
@LynxLynxx LynxLynxx merged commit 61cd6ee into main Jan 29, 2025
36 checks passed
@LynxLynxx LynxLynxx deleted the feat/1564-project-duration branch January 29, 2025 14:13
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F14 review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : User Input Component - Project duration months picker
3 participants