Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cat-voices): add automation for lace #1698

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

emiride
Copy link
Contributor

@emiride emiride commented Jan 27, 2025

Description

Re-enabled Lace tests in wallet automation

Related Issue(s)

Resolves #1602

Description of Changes

Few minor changes were needed to make tests a little bit more stable.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@emiride emiride self-assigned this Jan 27, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@emiride emiride marked this pull request as ready for review January 27, 2025 10:54
@emiride emiride added review me PR is ready for review F14 labels Jan 27, 2025
@emiride emiride requested a review from kukkok3 January 27, 2025 10:56
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) January 27, 2025 11:43
@kukkok3 kukkok3 self-requested a review January 27, 2025 11:43
@kukkok3 kukkok3 merged commit 1b04242 into main Jan 27, 2025
42 checks passed
@kukkok3 kukkok3 deleted the 1602-automation-for-lace branch January 27, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F14 review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add automation for Lace
2 participants