Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: placeholder and descriptions updated on the proposal template #1695

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

nathanbogale
Copy link
Contributor

Description of Changes

  • Added placeholders to each text field
  • Added guidelines for each section to provide clear instructions.
  • Updated description and guidance sections
  • Improved formatting for readability.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@nathanbogale nathanbogale added enhancement New feature or request review me PR is ready for review F14 labels Jan 26, 2025
@nathanbogale nathanbogale added this to the M4: Voting & Delegation milestone Jan 26, 2025
@nathanbogale nathanbogale self-assigned this Jan 26, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

dtscalac
dtscalac previously approved these changes Jan 27, 2025
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@minikin minikin enabled auto-merge (squash) January 28, 2025 08:53
@minikin minikin merged commit 022d5a2 into main Jan 28, 2025
36 checks passed
@minikin minikin deleted the proposal-template-modifications branch January 28, 2025 09:09
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request F14 review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants