Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): didUpdateWidget can't await async func #1680

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix(cat-voices): didUpdateWidget can't await async func #1680

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6751543
fix: didUpdate widget future await
LynxLynxx Jan 24, 2025
1cb06e6
Merge branch 'main' into fix/section_hero
LynxLynxx Jan 27, 2025
a8be78f
chore: making mounted check more secure
LynxLynxx Jan 27, 2025
df82dc5
Merge branch 'fix/section_hero' of github.com:input-output-hk/catalys…
LynxLynxx Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions catalyst_voices/apps/voices/lib/widgets/heroes/section_hero.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,12 @@ class _HeroSectionState extends State<HeroSection>
}

@override
Future<void> didUpdateWidget(covariant HeroSection oldWidget) async {
void didUpdateWidget(covariant HeroSection oldWidget) {
super.didUpdateWidget(oldWidget);

if (oldWidget.asset != widget.asset ||
oldWidget.assetPackageName != widget.assetPackageName) {
await _controller?.dispose();
_controller = VideoPlayerController.asset(
widget.asset,
package: widget.assetPackageName,
);
if (mounted) {
await _initalizedVideoPlayer();
}
unawaited(_disposeAndReinitializeVideoPlayer());
}
}

Expand Down Expand Up @@ -103,6 +96,17 @@ class _HeroSectionState extends State<HeroSection>
setState(() {});
}
}

Future<void> _disposeAndReinitializeVideoPlayer() async {
if (mounted) {
await _controller?.dispose();
_controller = VideoPlayerController.asset(
widget.asset,
package: widget.assetPackageName,
);
await _initalizedVideoPlayer();
}
}
LynxLynxx marked this conversation as resolved.
Show resolved Hide resolved
}

class _Background extends StatelessWidget {
Expand Down
Loading