-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-voices): copy catalystId #1679
Conversation
❌ Test Report | |
❌ Test Report | |
✅ Test Report | |
✅ Test Report | |
✅ Test Report | |
catalyst_voices/packages/internal/catalyst_voices_models/lib/src/user/account.dart
Show resolved
Hide resolved
❌ Test Report | |
❌ Test Report | |
❌ Test Report | |
✅ Test Report | |
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds
catalystId
toAccount
as well asCatalystIdText
widget according to designsRelated Issue(s)
Closes #1637
Description of Changes
Account.catalystId
. This is breaking change from existingAccountDto
where no migration makes sene. That's whySecureStorage
now supportsversions
.CatalystIdText
widget.Account.id
in favour ofAccount.catalystId
Screenshots
Please confirm the following checks