Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): copy catalystId #1679

Merged
merged 16 commits into from
Jan 28, 2025
Merged

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Jan 24, 2025

Description

This PR adds catalystId to Account as well as CatalystIdText widget according to designs

Related Issue(s)

Closes #1637

Description of Changes

  • Added Account.catalystId. This is breaking change from existing AccountDto where no migration makes sene. That's why SecureStorage now supports versions.
  • CatalystIdText widget.
  • Removed Account.id in favour of Account.catalystId

Screenshots

compact expanded
https://github.com/user-attachments/assets/94cd428f-d5bf-4708-8b97-c8830fb51d0b https://github.com/user-attachments/assets/3fc9dce6-e741-48ac-9389-ba29978f93e5

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Jan 24, 2025
@damian-molinski damian-molinski self-assigned this Jan 24, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 442/443}$ | ${\color{red}Fail: 1/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 442/443}$ | ${\color{red}Fail: 1/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@damian-molinski damian-molinski marked this pull request as ready for review January 27, 2025 11:44
@damian-molinski damian-molinski added the review me PR is ready for review label Jan 27, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 437/439}$ | ${\color{red}Fail: 2/439}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 437/439}$ | ${\color{red}Fail: 2/439}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 437/439}$ | ${\color{red}Fail: 2/439}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit bc31fa2 into main Jan 28, 2025
40 of 42 checks passed
@damian-molinski damian-molinski deleted the feat/copy_account_id_1637 branch January 28, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : CatalystID copy
3 participants