Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propose adr to use webp #167

Merged
merged 4 commits into from
Nov 30, 2023
Merged

feat: propose adr to use webp #167

merged 4 commits into from
Nov 30, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Nov 30, 2023

Description

Architecture decision record to use WebP format

Related Issue(s)

None

Description of Changes

As we develop our new cross-platform application (supporting Web, iOS, Android, macOS, Windows, and Linux),
we face a decision regarding the choice of image format. The selection of an image format is critical
for optimizing performance, load times, and the overall user experience across diverse platforms.

Breaking Changes

None

Screenshots

Not applicable

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin self-assigned this Nov 30, 2023
@minikin minikin added the review me PR is ready for review label Nov 30, 2023
@minikin minikin requested a review from stevenj November 30, 2023 12:49
@minikin minikin enabled auto-merge (squash) November 30, 2023 12:52
stevenj
stevenj previously approved these changes Nov 30, 2023
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin disabled auto-merge November 30, 2023 13:02
@minikin minikin merged commit b6b43a7 into main Nov 30, 2023
20 checks passed
@minikin minikin deleted the feature/adr-webp branch November 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants