Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): provide fallback for generic document string properties #1660

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

dtscalac
Copy link
Contributor

Description

In case a string property appears in the schema but it's not assigned to any known definition the app will provide a fallback for it so that the document can be filled.

Related Issue(s)

Refers #1410

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code F14 labels Jan 24, 2025
@dtscalac dtscalac added this to the Fund14 Technical Readiness milestone Jan 24, 2025
@dtscalac dtscalac self-assigned this Jan 24, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@dtscalac dtscalac merged commit 6353090 into main Jan 24, 2025
41 checks passed
@dtscalac dtscalac deleted the feat/fallback-for-generic-string-properties branch January 24, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code F14 review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants