Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cat-voices): try enabling integration tests #1533

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
+6 −23
Draft

test(cat-voices): try enabling integration tests #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
679a6a3
try enabling integration tests
oldGreg5 Jan 16, 2025
a6a9767
try with minimal tests
oldGreg5 Jan 16, 2025
c8d852a
try with minimal tests
oldGreg5 Jan 16, 2025
911bc5c
Merge branch 'main' into enable-integration-tests
oldGreg5 Jan 17, 2025
217a600
try with headless=new
oldGreg5 Jan 17, 2025
8d31e5e
try with headless
oldGreg5 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions catalyst_voices/apps/voices/integration_test/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ integration-test-web:
RUN ($driver --port=$driver_port > $driver.log &) && \
sleep 5 && \
flutter drive --driver=test_driver/integration_tests.dart \
--target=integration_test/app_test.dart \
--target=integration_test/all_test.dart \
-d web-server --browser-name=$browser --driver-port=$driver_port \
# https://github.com/flutter/flutter/issues/154727
--web-browser-flag=--disable-web-security \
--web-browser-flag=--disable-gpu \
--web-browser-flag=--headless=old \
--web-browser-flag=--headless \
--web-browser-flag=--disable-search-engine-choice-screen \
--profile || echo fail > fail
WAIT
Expand All @@ -49,7 +49,6 @@ integration-test-web:
# TODO(dtscalac): disabled integration tests due to them being flaky,
# reenable when enable-threads.js workaround is removed
# and https://github.com/fzyzcjy/flutter_rust_bridge/issues/2407 closed
disabled-test-web-all:
test-web-all:
BUILD +integration-test-web \
--browser=chrome \
--browser=firefox
--browser=chrome
6 changes: 2 additions & 4 deletions catalyst_voices/apps/voices/integration_test/all_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';

import 'suites/account_test.dart' as account_test;
import 'suites/app_test.dart' as app_test;
import 'suites/onboarding_test.dart' as onboarding_test;

void main() async {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
Expand All @@ -13,7 +11,7 @@ void main() async {
await bootstrap(router: buildAppRouter());
});

app_test.main();
onboarding_test.main();
// app_test.main();
// onboarding_test.main();
account_test.main();
}
14 changes: 0 additions & 14 deletions catalyst_voices/apps/voices/integration_test/suites/onboarding_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,19 +764,5 @@ void main() async {
},
);
},
skip: true,
);

patrolWidgetTest(
'visitor - restore - keychain choice screen looks OK',
(PatrolTester $) async {
await $.pumpWidgetAndSettle(App(routerConfig: router));
await $(AppBarPage.getStartedBtn).tap(settleTimeout: Time.long.duration);
await OnboardingPage.detailsPartGetStartedRecoverBtn($).tap();
await OnboardingPage.onboardingScreenLooksAsExpected(
$,
RegistrationState.keychainRestoreChoice,
);
},
);
}
Loading