Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Rich text component #1532

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Jan 16, 2025

Description

Users can enter rich text responses so that I can give long-form unstructured details about my proposal.

Related Issue(s)

Resolves #1414

Description of Changes

Changing VoicesRichText implementation to confirm to FormField protocol and to work with MultilineMarkdownDefiniton form schema

Screenshots

image image

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx self-assigned this Jan 16, 2025
@LynxLynxx LynxLynxx added comment me Request for comments ux/ui UX/UI related issues labels Jan 16, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@LynxLynxx LynxLynxx marked this pull request as ready for review January 17, 2025 08:41
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 374/378}$ | ${\color{red}Fail: 4/378}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@LynxLynxx LynxLynxx added review me PR is ready for review and removed comment me Request for comments labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : User Input Component - Rich Text
3 participants