Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): guarded get started #1528

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Jan 15, 2025

Description

This PR disables "Get Started" button when browser does not have wallet extensions installed.

Figma

Description of Changes

Trying to fetch list of wallets, falling back to empty list on any error.

Screenshots

in guest browser without extensions:

Screenshot 2025-01-16 at 10 10 58

with extensions:

Screenshot 2025-01-16 at 10 26 16

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Jan 15, 2025
@damian-molinski damian-molinski self-assigned this Jan 15, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 372/376}$ | ${\color{red}Fail: 4/376}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 372/376}$ | ${\color{red}Fail: 4/376}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 384/390}$ | ${\color{red}Fail: 6/390}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 39/39}$ | ${\color{red}Fail: 0/39}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/392}$ | ${\color{red}Fail: 6/392}$ |

@damian-molinski damian-molinski marked this pull request as ready for review January 17, 2025 09:49
@damian-molinski damian-molinski added the review me PR is ready for review label Jan 17, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 394/394}$ | ${\color{red}Fail: 0/394}$ |

Copy link
Contributor

@LynxLynxx LynxLynxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@damian-molinski damian-molinski added the do not merge yet PR is not ready to be merged yet label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants