Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates to opensource and definitions #1519

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nathanbogale
Copy link
Contributor

@nathanbogale nathanbogale commented Jan 14, 2025

Description

  • Modified the opensource section to meet with the requirement from ops team
  • added meta information to the proposal, that can be updated and give some guidance
  • modified patterns of some definitions

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@nathanbogale nathanbogale requested a review from stevenj January 15, 2025 17:50
nathanbogale and others added 2 commits January 16, 2025 20:30
…F14-Generic/0ce8ab38-9258-4fbc-a62e-7faa6e58318f.schema.json

Co-authored-by: Steven Johnson <[email protected]>
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) January 17, 2025 07:09
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

2 participants