Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): plain text component for single and multiline #1517

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Jan 14, 2025

Description

Component that allows user to input plain text as single line or multiline depending on the definition.

Related Issue(s)

Resolves #1413

Description of Changes

  • adding new components for single line and multiline
  • adding maxLengthEnforcement param to allow user to input more characters then max length but text field will show it's invalid.
  • small fix with resizebale height when maxlength is set
  • small fix to the placement of the text area icon when maxLength was set

Screenshots

Nagranie.z.ekranu.2025-01-14.o.13.15.04.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues labels Jan 14, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 14, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 35/35}$ | ${\color{red}Fail: 0/35}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@LynxLynxx LynxLynxx added the do not merge yet PR is not ready to be merged yet label Jan 14, 2025
@LynxLynxx LynxLynxx removed the do not merge yet PR is not ready to be merged yet label Jan 15, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski enabled auto-merge (squash) January 15, 2025 09:51
@damian-molinski damian-molinski merged commit d1fdfcf into main Jan 15, 2025
35 checks passed
@damian-molinski damian-molinski deleted the feat/1413-plain-text-component branch January 15, 2025 10:08
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : User Input Component - Plain Text
2 participants