Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): parse missing document properties, add validation #1503

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

feat(cat-voices): parse missing document properties, add validation #1503

wants to merge 43 commits into from
+3,791 −3,771

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Jan 10, 2025 •
edited
Loading

Description

Parses json schema array and object property types and adds validation.

  • Since json schema allows nesting each property can include child properties.
  • Updates UI widgets to build recursively UI for corresponding properties until the full document graph is traversed.

Related Issue(s)

Closes #1466

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added draft Draft dart Pull requests that update Dart code labels Jan 10, 2025
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Jan 10, 2025
@dtscalac dtscalac self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 374/385}$ | ${\color{red}Fail: 11/385}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 370/384}$ | ${\color{red}Fail: 14/384}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 372/384}$ | ${\color{red}Fail: 12/384}$ |

@damian-molinski damian-molinski mentioned this pull request Jan 15, 2025
Merged
8 tasks
@dtscalac
feat: wip
465df5e
@dtscalac
Merge branch 'main' into feat/parse-missing-document-properties
36318d0 
# Conflicts:
#	catalyst_voices/apps/voices/lib/widgets/tiles/document_builder_section_tile.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/definitions/nested_questions_definition.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/definitions/single_line_https_url_entry_definition.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/definitions/yes_no_choice_definition.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/document_validator.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/dto/document/schema/document_schema_property_dto.dart
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 361/369}$ | ${\color{red}Fail: 8/369}$ |

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 380/382}$ | ${\color{red}Fail: 2/382}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 382/382}$ | ${\color{red}Fail: 0/382}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 382/382}$ | ${\color{red}Fail: 0/382}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 372/372}$ | ${\color{red}Fail: 0/372}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 378/378}$ | ${\color{red}Fail: 0/378}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@dtscalac
Merge branch 'main' into feat/parse-missing-document-properties
9b8992d 
# Conflicts:
#	catalyst_voices/apps/voices/lib/widgets/tiles/document_builder_section_tile.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/catalyst_voices_models.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/document.dart
#	catalyst_voices/packages/internal/catalyst_voices_models/lib/src/document/document_schema.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/dto/document/document_dto.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/test/src/document/document_dto_test.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/test/src/document/schema/document_definitions_dto_test.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/test/src/document/schema/document_schema_dto_test.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/test/src/document/schema/document_schema_property_dto_test.dart
@dtscalac
chore: fix typo
f733a67
@dtscalac
chore: cleanup todos
2a56ff4
@dtscalac
fix: tests
2592e18
@dtscalac
chore: todo
6a9b0de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski Awaiting requested review from damian-molinski damian-molinski will be requested when the pull request is marked ready for review damian-molinski is a code owner

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx will be requested when the pull request is marked ready for review LynxLynxx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code draft Draft
Projects
Catalyst
Status: 🏗 In progress
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Parse and add validation logic for document properties
1 participant
@dtscalac