Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): Add memory metrics to improve observability #1499

Merged
merged 20 commits into from
Jan 16, 2025
Merged

feat(cat-gateway): Add memory metrics to improve observability #1499

merged 20 commits into from
Jan 16, 2025

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jan 9, 2025 •
edited
Loading

Description

Added memory metrics functionality to cat-gateway.

Related Issue(s)

Closes #1496

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added draft Draft rust Pull requests that update Rust code labels Jan 9, 2025
@apskhem apskhem self-assigned this Jan 9, 2025
@apskhem apskhem marked this pull request as draft January 9, 2025 13:54
@apskhem apskhem linked an issue Jan 9, 2025 that may be closed by this pull request
🛠️ [TASK] : Add memory metrics to improve observability #1496
Closed
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@apskhem apskhem marked this pull request as ready for review January 13, 2025 16:05
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@minikin minikin mentioned this pull request Jan 13, 2025
Open
@apskhem apskhem marked this pull request as draft January 14, 2025 08:52
Mr-Leshiy
Mr-Leshiy previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Base automatically changed from feat/improve-observability to main January 15, 2025 03:21
@stevenj stevenj dismissed Mr-Leshiy’s stale review January 15, 2025 03:21

The base branch was changed.

@apskhem apskhem added draft Draft and removed review me PR is ready for review labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Jan 15, 2025
@apskhem apskhem marked this pull request as ready for review January 15, 2025 16:04
@apskhem apskhem requested a review from Mr-Leshiy January 15, 2025 16:04
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

stevenj
stevenj approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read my comment, but LGTM.

catalyst-gateway/bin/src/metrics/memory.rs Show resolved Hide resolved
@stevenj stevenj merged commit 21263b1 into main Jan 16, 2025
41 checks passed
@stevenj stevenj deleted the feat/memory-metrics branch January 16, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

Assignees

@apskhem apskhem

Labels
review me PR is ready for review rust Pull requests that update Rust code
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add memory metrics to improve observability
3 participants
@apskhem @stevenj @Mr-Leshiy