New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cat-voices): Store and restore seeds during onboarding create #1490

Merged

oldGreg5 merged 27 commits into main from 1453-task-integration-tests-continue-automating-onboarding-flow-part-2

Jan 16, 2025

Contributor

oldGreg5 commented Jan 9, 2025 •

edited

Loading

Description

Add store and restore seeds during onboarding create

Related Issue(s)

Description of Changes

Tests added:

add store and restore seeds during onboarding create
password info screen checks
password input screen checks with basic password validation
keychain created success screen check
link wallet info screen check
link wallet select screen check

Breaking Changes

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module


          store and restore seeds during onboarding create

8f348d1

oldGreg5 requested review from dtscalac, damian-molinski and LynxLynxx as code owners

January 9, 2025 09:47

oldGreg5 linked an issue

that may be closed by this pull request

🛠️ [TASK] : Integration tests, continue automating onboarding flow, part 2 #1453

Closed

oldGreg5 requested review from emiride and kukkok3

January 9, 2025 09:50


          style fix

798d4ea

Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 379/379}$ | ${\color{red}Fail: 0/379}$ |

Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 379/379}$ | ${\color{red}Fail: 0/379}$ |

oldGreg5 added 2 commits

January 9, 2025 11:12


          style fix

13b3f93


          style fix

cd7ea6c

oldGreg5 marked this pull request as draft

January 9, 2025 10:16

Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 379/379}$ | ${\color{red}Fail: 0/379}$ |

Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 379/379}$ | ${\color{red}Fail: 0/379}$ |

minikin assigned oldGreg5

minikin added the draft label

oldGreg5 added 2 commits

January 10, 2025 12:58


          Merge branch 'refs/heads/main' into 1453-task-integration-tests-conti…

…nue-automating-onboarding-flow-part-2


          few more tests

d515b80

Contributor

github-actions bot commented Jan 10, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |


          add keychain created success test

8c07d84

oldGreg5 marked this pull request as ready for review

January 10, 2025 14:01

oldGreg5 added review me and removed draft labels

Contributor

github-actions bot commented Jan 10, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

oldGreg5 added 2 commits

January 10, 2025 15:25


          cleanup

1a38ce0


          formatting fix

7bb40b8

Contributor

github-actions bot commented Jan 10, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

oldGreg5 enabled auto-merge (squash)

January 10, 2025 14:37

Contributor

github-actions bot commented Jan 10, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Contributor

github-actions bot commented Jan 13, 2025

❌ Test Report | ${\color{lightgreen}Pass: 381/384}$ | ${\color{red}Fail: 3/384}$ |


          Merge branch 'main' into 1453-task-integration-tests-continue-automat…

67e9176

…ing-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 13, 2025

✅ Test Report | ${\color{lightgreen}Pass: 384/384}$ | ${\color{red}Fail: 0/384}$ |


          Merge branch 'main' into 1453-task-integration-tests-continue-automat…

fa3d247

…ing-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 14, 2025

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |


          Merge branch 'main' into 1453-task-integration-tests-continue-automat…

000ac53

…ing-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 14, 2025

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |


          Merge branch 'main' into 1453-task-integration-tests-continue-automat…

0e82662

…ing-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 14, 2025

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

oldGreg5 added 3 commits

January 15, 2025 10:55


          Merge remote-tracking branch 'refs/remotes/origin/main' into 1453-tas…

70c8c0f

…k-integration-tests-continue-automating-onboarding-flow-part-2


          2 restore flow tests

8570c91


          Merge remote-tracking branch 'origin/1453-task-integration-tests-cont…

020e541

…inue-automating-onboarding-flow-part-2' into 1453-task-integration-tests-continue-automating-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 15, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |


          Merge branch 'main' into 1453-task-integration-tests-continue-automat…

9b11694

…ing-onboarding-flow-part-2

Contributor

github-actions bot commented Jan 15, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

kukkok3 reviewed

View reviewed changes

catalyst_voices/apps/voices/integration_test/suites/onboarding_test.dart Show resolved Hide resolved

kukkok3 reviewed

View reviewed changes

catalyst_voices/apps/voices/integration_test/suites/onboarding_test.dart Show resolved Hide resolved

kukkok3 reviewed

View reviewed changes

catalyst_voices/apps/voices/integration_test/suites/onboarding_test.dart Outdated Show resolved Hide resolved

kukkok3 requested changes

View reviewed changes

Contributor

kukkok3 left a comment

See comments

oldGreg5 added 2 commits

January 16, 2025 12:35


          Merge branch 'refs/heads/main' into 1453-task-integration-tests-conti…

cbdaa7c

…nue-automating-onboarding-flow-part-2


          pr comments

eb9732d

oldGreg5 requested a review from kukkok3

January 16, 2025 11:36

oldGreg5 added 2 commits

January 16, 2025 12:37

bit

c6501ba


          cleanup

ea0b1cc

Contributor

github-actions bot commented Jan 16, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Contributor

github-actions bot commented Jan 16, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Contributor

github-actions bot commented Jan 16, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

kukkok3 approved these changes

View reviewed changes

Contributor

kukkok3 left a comment

LGTM

oldGreg5 merged commit 2f3bbbe into main

41 checks passed

oldGreg5 deleted the 1453-task-integration-tests-continue-automating-onboarding-flow-part-2 branch

January 16, 2025 12:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kukkok3 kukkok3 approved these changes

dtscalac Awaiting requested review from dtscalac dtscalac is a code owner

damian-molinski Awaiting requested review from damian-molinski damian-molinski is a code owner

LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx is a code owner

emiride Awaiting requested review from emiride

Labels