Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-gateway): Add document endpoints #1470

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Jan 6, 2025

Description

Adds the Signed Document endpoints

Related Issue(s)

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj self-assigned this Jan 6, 2025
@stevenj stevenj marked this pull request as draft January 6, 2025 07:34
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@minikin minikin added the draft Draft label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@neil-iohk
Copy link

neil-iohk commented Jan 7, 2025

@stevenj Following our conversation earlier I took a look here again, you mentioned using jsonrpc for our API, if so are we going to follow a specific version like 2.0 https://www.jsonrpc.org/specification.

While the spec doesn't explicitly say that method is required it is inferred based on the rest of the context around request format like params where it states it MAY be omitted, if we are following this spec, what approach do you want to take to specify the method, a single document method, or more granular depending on usecase? Should these be defined along with the actions, while they may not be entity specific and more general a list of these may help cover a lot of the usecase examples listed in the API doc.

Depending on the approach here I will hold off updating anything to reflect discussions this morning and I can move relevant API sections into the docs later

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Report | ${\color{lightgreen}Pass: 371/371}$ | ${\color{red}Fail: 0/371}$ |

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 371/371}$ | ${\color{red}Fail: 0/371}$ |

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 373/373}$ | ${\color{red}Fail: 0/373}$ |

@Mr-Leshiy Mr-Leshiy force-pushed the feat/add-doc-endpoints branch from f5ef33e to 195f879 Compare January 9, 2025 10:36
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 381/381}$ | ${\color{red}Fail: 0/381}$ |

@Mr-Leshiy Mr-Leshiy force-pushed the feat/add-doc-endpoints branch from 54f0075 to fd95bac Compare January 13, 2025 08:36
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@stevenj stevenj marked this pull request as ready for review January 15, 2025 03:22
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 386/387}$ | ${\color{red}Fail: 1/387}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 387/387}$ | ${\color{red}Fail: 0/387}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@stevenj stevenj merged commit f9eca94 into main Jan 15, 2025
41 checks passed
@stevenj stevenj deleted the feat/add-doc-endpoints branch January 15, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Draft
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants