Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flutter/catalyst_compression): catalyst compression doesn't load in dev #1207

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Catalyst compression doesn't load in dev due to wrong CORS/CORP headers that are set by 3rd party server serving dependent assets.

We copy these assets from 3rd party server into our own package so that our own server will serve them with correct headers.

Additionally a workaround (enable-threads.js) has been removed from catalyst_cardano_example, we can provide custom headers when running the app instead of using the workaround.

Screenshots

Screenshot 2024-11-13 at 16 45 24

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added bug Something isn't working review me PR is ready for review dart Pull requests that update Dart code labels Nov 13, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Nov 13, 2024
@dtscalac dtscalac self-assigned this Nov 13, 2024
@dtscalac dtscalac removed the request for review from stevenj November 13, 2024 15:48
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 327/327}$ | ${\color{red}Fail: 0/327}$ |

@dtscalac dtscalac merged commit 5745ee9 into main Nov 14, 2024
38 checks passed
@dtscalac dtscalac deleted the fix/catalyst_compression_doesnt_load_in_dev branch November 14, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants