Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-gateway): Purge volatile data after immutable roll forward #1188

Merged
merged 61 commits into from
Jan 17, 2025
Merged

feat(cat-gateway): Purge volatile data after immutable roll forward #1188

merged 61 commits into from
Jan 17, 2025

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Nov 11, 2024 •
edited
Loading

Description

Adds queries and logic for purgin volatile DB data.

Related Issue(s)

Closes #944

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added the draft Draft label Nov 11, 2024
@saibatizoku saibatizoku added this to the M4: Voting & Delegation milestone Nov 11, 2024
@saibatizoku saibatizoku self-assigned this Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 291/291}$ | ${\color{red}Fail: 0/291}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 291/291}$ | ${\color{red}Fail: 0/291}$ |

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from f5e7329 to a8bbb04 Compare November 12, 2024 15:06
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 291/291}$ | ${\color{red}Fail: 0/291}$ |

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from a8bbb04 to be5e37c Compare November 12, 2024 15:51
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 291/291}$ | ${\color{red}Fail: 0/291}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 291/291}$ | ${\color{red}Fail: 0/291}$ |

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from 447e1db to 85b532f Compare November 13, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 298/298}$ | ${\color{red}Fail: 0/298}$ |

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from 85b532f to 6e2ae43 Compare November 14, 2024 02:30
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 298/298}$ | ${\color{red}Fail: 0/298}$ |

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from 6e2ae43 to 6564784 Compare November 14, 2024 19:20
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from 6564784 to 86b837d Compare November 21, 2024 15:06
@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from e238a68 to c0056ff Compare December 2, 2024 13:41
@saibatizoku saibatizoku force-pushed the feat/purge-volatile-data-after-roll-forward branch from c0056ff to 84afb16 Compare December 4, 2024 20:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@cong-or cong-or removed the do not merge yet PR is not ready to be merged yet label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@Mr-Leshiy Mr-Leshiy force-pushed the feat/purge-volatile-data-after-roll-forward branch from 9b84c51 to cf1f2a4 Compare January 17, 2025 11:43
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@Mr-Leshiy Mr-Leshiy force-pushed the feat/purge-volatile-data-after-roll-forward branch from cf1f2a4 to cad64ff Compare January 17, 2025 12:58
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 391/392}$ | ${\color{red}Fail: 1/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

@cong-or cong-or self-requested a review January 17, 2025 13:40
cong-or
cong-or approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cong-or cong-or marked this pull request as ready for review January 17, 2025 13:40
@cong-or cong-or merged commit 5c875d3 into main Jan 17, 2025
41 checks passed
@cong-or cong-or deleted the feat/purge-volatile-data-after-roll-forward branch January 17, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cong-or cong-or cong-or approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@minikin minikin Awaiting requested review from minikin

@bkioshn bkioshn Awaiting requested review from bkioshn bkioshn is a code owner

@stanislav-tkach stanislav-tkach Awaiting requested review from stanislav-tkach stanislav-tkach is a code owner

Assignees

@saibatizoku saibatizoku

Labels
review me PR is ready for review
Projects
Catalyst
Status: ✅ Done
Milestone
M4: Voting & Delegation
4 participants
@saibatizoku @cong-or @stevenj @Mr-Leshiy