pr comments

input-output-hk · Jan 16, 2025 · eb9732d · eb9732d
1 parent cbdaa7c
commit eb9732d
Show file tree

Hide file tree

Showing 4 changed files with 71 additions and 41 deletions.
diff --git a/catalyst_voices/apps/voices/integration_test/suites/account_test.dart b/catalyst_voices/apps/voices/integration_test/suites/account_test.dart
@@ -9,6 +9,7 @@ import 'package:patrol_finders/patrol_finders.dart';
 import '../pageobject/account_dropdown_page.dart';
 import '../pageobject/app_bar_page.dart';
 import '../pageobject/overall_spaces_page.dart';
+import '../utils/constants.dart';
 
 void main() async {
   late final GoRouter router;
@@ -34,7 +35,7 @@ void main() async {
         (PatrolTester $) async {
           await $.pumpWidgetAndSettle(App(routerConfig: router));
           await $(OverallSpacesPage.userShortcutBtn)
-              .tap(settleTimeout: const Duration(seconds: 10));
+              .tap(settleTimeout: TimeConstants.long.duration);;
           await $(AppBarPage.accountPopupBtn).tap();
           await AccountDropdownPage.accountDropdownLooksAsExpected($);
           await AccountDropdownPage.accountDropdownContainsSpecificData($);

diff --git a/catalyst_voices/apps/voices/integration_test/suites/app_test.dart b/catalyst_voices/apps/voices/integration_test/suites/app_test.dart
@@ -10,6 +10,7 @@ import 'package:patrol_finders/patrol_finders.dart';
 import '../pageobject/app_bar_page.dart';
 import '../pageobject/overall_spaces_page.dart';
 import '../pageobject/spaces_drawer_page.dart';
+import '../utils/constants.dart';
 import '../utils/selector_utils.dart';
 
 void main() async {
@@ -34,7 +35,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.visitorShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         expect($(AppBarPage.spacesDrawerButton).exists, false);
       },
     );
@@ -46,7 +47,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.guestShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
         SpacesDrawerPage.commonElementsLookAsExpected($);
 
@@ -66,7 +67,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.guestShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
 
         // iterate thru spaces by clicking next
@@ -92,7 +93,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.userShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
         SpacesDrawerPage.commonElementsLookAsExpected($);
         for (final space in Space.values) {
@@ -107,7 +108,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.guestShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
         await $(SpacesDrawerPage.allSpacesBtn).tap();
         expect($(OverallSpacesPage.spacesListView), findsOneWidget);
@@ -119,7 +120,7 @@ void main() async {
       (PatrolTester $) async {
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.userShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
         await $(SpacesDrawerPage.allSpacesBtn).tap();
         expect($(OverallSpacesPage.spacesListView), findsOneWidget);
@@ -138,7 +139,7 @@ void main() async {
         };
         await $.pumpWidgetAndSettle(App(routerConfig: router));
         await $(OverallSpacesPage.userShortcutBtn)
-            .tap(settleTimeout: const Duration(seconds: 10));
+            .tap(settleTimeout: TimeConstants.long.duration);
         await $(AppBarPage.spacesDrawerButton).waitUntilVisible().tap();
         for (final space in Space.values) {
           await $(SpacesDrawerPage.chooserItem(space)).tap();