Add benchmarks and update Plutarch version #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mueller
requested changes
Jan 20, 2025
|
|
||
| ## Target Performance | ||
|
|
||
| The target performance for our library is a reduction of 30% ex-units across the above benchmarks. |
There was a problem hiding this comment.
Is there something missing in the report?
There was a problem hiding this comment.
Report (M1) was just providing benchmarks for Plinth / Aiken and establishing our target benchmarks (which we stated must be an improvement upon existing benchmarks). What we actually achieved was (in most cases) much better than the above target (often 80%+ reduction in ex-units).
| {-# LANGUAGE GADTs #-} | ||
| {-# LANGUAGE RankNTypes #-} | ||
|
|
||
| module Plutarch.Core.FieldBinds where |
| {-# LANGUAGE QualifiedDo #-} | ||
| {-# LANGUAGE PolyKinds #-} | ||
| {-# LANGUAGE OverloadedRecordDot #-} | ||
| module Plutarch.Core.Time where |
| @@ -0,0 +1,134 @@ | |||
| {-# LANGUAGE OverloadedRecordDot #-} | |||
|
|
|||
| module Plutarch.Core.ValidationLogic where | |||
| {-# LANGUAGE RankNTypes #-} | ||
| {-# LANGUAGE PartialTypeSignatures #-} | ||
|
|
||
| module Plutarch.Core.Value where |
| import Plutarch.MerkleTree.Helpers (pcombine, pnibble, pnibbles, | ||
| psuffix) | ||
| import Plutarch.MerkleTree.Merkling (pmerkle_16, pnull_hash, | ||
| psparse_merkle_16) | ||
| import Plutarch.Prelude | ||
| import PlutusLedgerApi.V2 (BuiltinByteString) | ||
| import PlutusTx.Builtins.Internal (BuiltinByteString (BuiltinByteString)) | ||
| --import PlutusLedgerApi.V2 (BuiltinByteString) |
|
|
||
| instance PUnsafeLiftDecl PMerklePatriciaForestry where | ||
| type PLifted PMerklePatriciaForestry = MerklePatriciaForestry | ||
| -- instance |
| -- type AsHaskell PMerklePatriciaForestry = BuiltinByteString | ||
| -- type PlutusRepr PMerklePatriciaForestry = PLiftedClosed PMerklePatriciaForestry | ||
|
|
||
| instance {-# OVERLAPPING #-} PLiftable PMerklePatriciaForestry where |
There was a problem hiding this comment.
Why do we need the overlappable pragma here?
| {-# INLINEABLE fromPlutarch #-} | ||
| fromPlutarch = fromPlutarchUni | ||
|
|
||
| -- deriving via |
|
Also the build is failing because of some warnings |
j-mueller
reviewed
Jan 22, 2025
| @@ -16,7 +16,7 @@ repository cardano-haskell-packages | |||
|
|
|||
| index-state: | |||
| , hackage.haskell.org 2024-10-10T00:52:24Z | |||
| , cardano-haskell-packages 2024-10-24T10:49:32Z | |||
| , cardano-haskell-packages 2024-10-09T22:38:57Z | |||
There was a problem hiding this comment.
Why are we going backwards in time here?
j-mueller
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced benchmarks and updated the Plutarch version. The benchmark results are extremely promising. The custom library functions blow the standard library ones out of the water:
Recursiveis the std lib equivalent when it exists, fast is our optimized implementation. The results are astonishing, our implementations are often dozens of times more efficient even for trivial functions likelength.