Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): Small assorted improvements #183

Merged
merged 23 commits into from
Jan 28, 2025
Merged

feat(general): Small assorted improvements #183

merged 23 commits into from
Jan 28, 2025

Conversation

stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 27, 2025 •
edited
Loading

Description

  • Add the purpose getter to Cip509.
  • Export the Cip509RbacMetadata type.
  • Add the define_hashes macro.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@stanislav-tkach stanislav-tkach changed the title feat(rust/rbac-registration): Add the purpose getter function to Cip509 feat(general): Add the purpose getter function to Cip509 Jan 27, 2025
@stanislav-tkach stanislav-tkach changed the title feat(general): Add the purpose getter function to Cip509 feat(general): Some improvements Jan 27, 2025
@stanislav-tkach stanislav-tkach changed the title feat(general): Some improvements feat(general): Small assorted improvements Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@stanislav-tkach stanislav-tkach requested review from bkioshn, Mr-Leshiy and stevenj and removed request for bkioshn and Mr-Leshiy January 27, 2025 18:54
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy
Mr-Leshiy requested changes Jan 28, 2025
View reviewed changes
rust/cardano-blockchain-types/src/hashes.rs Outdated Show resolved Hide resolved
rust/cardano-blockchain-types/src/hashes.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/hashes.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/uuid/uuid_v4.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/uuid/uuid_v7.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy
Mr-Leshiy approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanislav-tkach stanislav-tkach merged commit e251dea into main Jan 28, 2025
20 of 22 checks passed
@stanislav-tkach stanislav-tkach deleted the cip509-purpose-getter branch January 28, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj Awaiting requested review from stevenj

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanislav-tkach @Mr-Leshiy