-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust/cardano-chain-follower): Refactor chain follower to use cardano-blockchain-types
#115
Conversation
…ardano-blockchain-types Signed-off-by: bkioshn <[email protected]>
cardano-blockchain-types
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
Mostly, I think we need to add some features to the Fork type, and then incorporate those into this code.
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
✅ Test Report | |
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Refactor
cardano-chain-follower
to usecardano-blockchain-types
Related Issue(s)
#121
Description of Changes
cardano-blockchain-types
include - Slot, Network, Txn_Index, Fork etc.follow_chain.rs
stat.rs
metadata
catalyst-types
Breaking Changes
All crate that originally use
cardanno-chain-follower
need to beware ofu64 -> Slot
etc.metadata
module is now removedPlease confirm the following checks