This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Minor Updates #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 25, 2015 15:52
Callback was only being checked to be a function in one location, not
everytime it was used. Instead callback is now checked to be a function
at the top otherwise a empty function is assigned to it so the
executions don’t cause errors.
```
/node_modules/fancy-errors/lib/index.js:64
callback(err);
^
TypeError: undefined is not a function
at Object.catchErr [as catch]
(/node_modules/fancy-errors/lib/index.js:64:7)
```
The dependency on the node env variable felt too much like a side effect we couldn’t control. Would prefer to pass an option to print pretty and not have it override the stack trace value, rather have a function that returns a prettified stack trace for logging.
|
@benjaminpearson Should we archive this repo? Seems pretty untouched. Having a look at migration paths now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefinedwhen being executed. For instance in/lib/index.jsthecatchErrandcatchNamedErrit was not silently catching errors if you didn't have a callback defined.prettywon't be being called at the moment. Ideally the function would be changed to allow an option for printing pretty and not replace the existing stack trace with a new version (because we want the normal stack trace to be available for some log outlets such as Loggly or Sentry). We've removed it and used the logic of pretty formatting separately in our application logging code base for now.