Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace homePath with default if it's empty #45

Closed
wants to merge 1 commit into from
Closed

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jan 9, 2024

if we run initiad without --home, L421 returns empty string.
so i think replacing with DefaultNodeHome if homePath is empty will prevent upgradeKeeper's odd behavior(downloading binaries into cwd i guess).

if this pr approved, i'll make a pr for cosmos-sdk/simapp also :)

@Vritra4 Vritra4 requested review from beer-1 and a team January 9, 2024 02:24
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44bed60) 38.87% compared to head (6373777) 38.89%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   38.87%   38.89%   +0.01%     
==========================================
  Files         162      162              
  Lines       16749    16752       +3     
==========================================
+ Hits         6512     6515       +3     
  Misses       9138     9138              
  Partials     1099     1099              
Files Coverage Δ
app/app.go 85.06% <100.00%> (+0.05%) ⬆️

@Vritra4 Vritra4 closed this Jan 9, 2024
@Vritra4 Vritra4 deleted the fix/homepath branch January 9, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant