Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint #41

Merged
merged 2 commits into from
Jan 8, 2024
Merged

chore: lint #41

merged 2 commits into from
Jan 8, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jan 7, 2024

just adding error checks and removing unnecessary type conversions

@Vritra4 Vritra4 requested review from beer-1 and a team January 7, 2024 07:52
@Vritra4 Vritra4 self-assigned this Jan 7, 2024
@Vritra4
Copy link
Contributor Author

Vritra4 commented Jan 7, 2024

fixed a few links in README.md, but some missing links are still there.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 1722 lines in your changes are missing coverage. Please review.

Comparison is base (48f6c57) 39.18% compared to head (fe65359) 38.88%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   39.18%   38.88%   -0.31%     
==========================================
  Files         162      162              
  Lines       16694    16756      +62     
==========================================
- Hits         6542     6516      -26     
- Misses       9067     9139      +72     
- Partials     1085     1101      +16     
Files Coverage Δ
app/genesis.go 43.43% <100.00%> (ø)
x/distribution/autocli.go 100.00% <100.00%> (ø)
x/distribution/types/codec.go 0.00% <ø> (ø)
x/distribution/types/params.go 66.66% <100.00%> (ø)
x/genutil/genesis.go 40.00% <ø> (ø)
x/gov/types/codec.go 0.00% <ø> (ø)
x/gov/types/genesis.go 73.07% <100.00%> (ø)
x/gov/types/params.go 62.19% <ø> (ø)
x/ibc/nft-transfer/keeper/genesis.go 17.24% <ø> (ø)
x/ibc/nft-transfer/keeper/grpc_query.go 2.56% <ø> (ø)
... and 106 more

... and 6 files with indirect coverage changes

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 4cc5287 into main Jan 8, 2024
6 of 7 checks passed
@beer-1 beer-1 deleted the chore/lint branch January 8, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants