add more assertions

initia-labs · Nov 6, 2024 · c3537a8 · c3537a8
1 parent 601db42
commit c3537a8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/app/lanes/mempool.go b/app/lanes/mempool.go
@@ -53,6 +53,11 @@ func NewMempool[C comparable](
 ) (*Mempool[C], error) {
 	if !ratio.IsPositive() {
 		return nil, errors.New("mempool creation; ratio must be positive")
+	} else if ratio.GT(math.LegacyOneDec()) {
+		return nil, errors.New("mempool creation; ratio must be less than or equal to 1")
+	}
+	if txEncoder == nil {
+		return nil, errors.New("mempool creation; tx encoder is nil")
 	}
 
 	return &Mempool[C]{

diff --git a/app/lanes/mempool_test.go b/app/lanes/mempool_test.go
@@ -34,6 +34,28 @@ func Test_MempoolInsert(t *testing.T) {
 	signerExtractor := signer_extraction.NewDefaultAdapter()
 	encodingConfig := params.MakeEncodingConfig()
 	txEncoder := encodingConfig.TxConfig.TxEncoder()
+
+	// cannot create mempool with negative ratio
+	_, err := lanes.NewMempool(
+		blockbase.NewDefaultTxPriority(),
+		signerExtractor,
+		1, // max txs
+		math.LegacyNewDecFromInt(math.NewInt(-1)), // max block space
+		txEncoder,
+	)
+	require.Error(t, err)
+
+	// cannot create mempool with ratio greater than 1
+	_, err = lanes.NewMempool(
+		blockbase.NewDefaultTxPriority(),
+		signerExtractor,
+		1,                                        // max txs
+		math.LegacyNewDecFromInt(math.NewInt(2)), // max block space
+		txEncoder,
+	)
+	require.Error(t, err)
+
+	// valid creation
 	mempool, err := lanes.NewMempool(
 		blockbase.NewDefaultTxPriority(),
 		signerExtractor,